From d3c1d0f65390dd595441ac3dca1cf52db790ddad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20D?= Date: Mon, 6 Feb 2023 15:48:22 +0100 Subject: [PATCH] Fix issue where octodns was failing on missing TTL value for NS records in PTR zones --- octodns_netbox_dns/__init__.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/octodns_netbox_dns/__init__.py b/octodns_netbox_dns/__init__.py index e14c54f..291617b 100644 --- a/octodns_netbox_dns/__init__.py +++ b/octodns_netbox_dns/__init__.py @@ -110,10 +110,18 @@ class NetBoxDNSSource(octodns.provider.base.BaseProvider): name = nb_record.name if name == "@": name = "" + + nb_zone_default_ttl = nb_zone.default_ttl + if nb_record.ttl: + nb_ttl = nb_record.ttl + elif nb_record.type == "NS": + nb_ttl = nb_zone.soa_refresh + else: + nb_ttl = nb_zone_default_ttl data = { "name": name, "type": nb_record.type, - "ttl": nb_record.ttl, + "ttl": nb_ttl, "values": [], } rdata = dns.rdata.from_text("IN", nb_record.type, nb_record.value)