Signed-off-by: Ivan Schaller <ivan@schaller.sh>
This commit is contained in:
parent
f1f6602985
commit
9efd4faea1
2 changed files with 6 additions and 5 deletions
|
@ -79,7 +79,6 @@ class NetBoxDNSProvider(octodns.provider.base.BaseProvider):
|
||||||
"""return dns name with trailing dot to make it absolute
|
"""return dns name with trailing dot to make it absolute
|
||||||
|
|
||||||
@param value: dns record value
|
@param value: dns record value
|
||||||
|
|
||||||
@param force: when `True`, disregard configuration option `make_absolute`
|
@param force: when `True`, disregard configuration option `make_absolute`
|
||||||
|
|
||||||
@return: absolute dns record value
|
@return: absolute dns record value
|
||||||
|
@ -443,6 +442,6 @@ class NetBoxDNSProvider(octodns.provider.base.BaseProvider):
|
||||||
"""
|
"""
|
||||||
query_params = {"status": "active", **self.nb_view}
|
query_params = {"status": "active", **self.nb_view}
|
||||||
zones = self.api.plugins.netbox_dns.zones.filter(**query_params)
|
zones = self.api.plugins.netbox_dns.zones.filter(**query_params)
|
||||||
zones = [self._make_absolute(z.name, True) for z in zones]
|
absolute_zones = [self._make_absolute(z.name, True) for z in zones]
|
||||||
|
|
||||||
return sorted(zones)
|
return sorted(absolute_zones)
|
||||||
|
|
|
@ -26,6 +26,7 @@ def test_noop():
|
||||||
|
|
||||||
assert absolute == "example.com."
|
assert absolute == "example.com."
|
||||||
|
|
||||||
|
|
||||||
def test_disabled():
|
def test_disabled():
|
||||||
args = {**DEFAULT_CONFIG, "make_absolute": False}
|
args = {**DEFAULT_CONFIG, "make_absolute": False}
|
||||||
nbdns = NetBoxDNSProvider(**args)
|
nbdns = NetBoxDNSProvider(**args)
|
||||||
|
@ -34,6 +35,7 @@ def test_disabled():
|
||||||
|
|
||||||
assert relative == "example.com"
|
assert relative == "example.com"
|
||||||
|
|
||||||
|
|
||||||
def test_force():
|
def test_force():
|
||||||
args = {**DEFAULT_CONFIG, "make_absolute": False}
|
args = {**DEFAULT_CONFIG, "make_absolute": False}
|
||||||
nbdns = NetBoxDNSProvider(**args)
|
nbdns = NetBoxDNSProvider(**args)
|
||||||
|
|
Loading…
Reference in a new issue