olofvndrhr/octodns-netbox-dns
1
0
Fork 0
Code Issues 1 Pull requests 5 Projects Releases 7 Packages Wiki Activity Actions

change from repr to string in changeset
All checks were successful
check code / check-code (push) Successful in 30s
Details

Browse source 
Signed-off-by: Ivan Schaller <ivan@schaller.sh>
This commit is contained in:
Ivan Schaller 2024-03-01 19:37:16 +01:00
parent 4fe8be6291
commit 696d2a2532
2 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/octodns_netbox_dns/__init__.py
View file

@ -91,12 +91,12 @@ class NetBoxDNSProvider(octodns.provider.base.BaseProvider):
return absolute_value
def _escape_semicolon(self, value: str) -> str:
fixed = value.replace(";", "\\;")
fixed = value.replace(";", r"\;")
self.log.debug(rf"in='{value}', escaped='{fixed}'")
return fixed
def _unescape_semicolon(self, value: str) -> str:
fixed = value.replace("\\\\", "\\").replace("\\;", ";")
fixed = value.replace(r"\;", ";")
self.log.debug(rf"in='{value}', unescaped='{fixed}'")
return fixed
@ -317,9 +317,10 @@ class NetBoxDNSProvider(octodns.provider.base.BaseProvider):
"""
match change:
case octodns.record.ValueMixin():
changeset = {repr(change.value)[1:-1]}
changeset = {str(change.value)}
case octodns.record.ValuesMixin():
changeset = {repr(v)[1:-1] for v in change.values}
changeset = {str(v) for v in change.values}
case _:
raise ValueError

4
tests/test_escaple_semicolon.py
View file

@ -56,7 +56,7 @@ def test_unescape2():
rcd_value = r"v=TLSRPTv1\\; rua=mailto:tlsrpt@example.com"
value = nbdns._unescape_semicolon(rcd_value)
assert value == r"v=TLSRPTv1; rua=mailto:tlsrpt@example.com"
assert value == r"v=TLSRPTv1\; rua=mailto:tlsrpt@example.com"
def test_unescape3():
@ -64,7 +64,7 @@ def test_unescape3():
rcd_value = r"t=y\\;o=~\;"
value = nbdns._unescape_semicolon(rcd_value)
assert value == r"t=y;o=~;"
assert value == r"t=y\;o=~;"
def test_unescape4():