olofvndrhr
/
octodns-netbox-dns
1
0
Fork 0
Code Issues 1 Pull Requests 9 Actions Packages Projects Releases 4 Wiki Activity

Merge pull request #8 from LuPo/regr_type_hints 

pynetbox Record type as parameter value passed to get_nb_zone
This commit is contained in:
Jeffrey C. Ollie 2022-10-17 10:16:44 -05:00 committed by GitHub
parent ffcbcfc0f5 693ea86629
commit 3dd15f6b4b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
octodns_netbox_dns/__init__.py
View File

@ -8,7 +8,7 @@ import octodns.provider.plan
import octodns.record
import octodns.zone
import pynetbox.core.api
import pynetbox.core.response
import pynetbox.core.response as pynb_resp
class NetBoxDNSSource(octodns.provider.base.BaseProvider):
@ -60,7 +60,7 @@ class NetBoxDNSSource(octodns.provider.base.BaseProvider):
_api: pynetbox.core.api.Api
# log: logging.Logger
_nb_view: pynetbox.core.response.Record | None
_nb_view: pynb_resp.Record | None
_ttl: int
def __init__(
@ -82,11 +82,11 @@ class NetBoxDNSSource(octodns.provider.base.BaseProvider):
self._ttl = ttl
self.replace_duplicates = replace_duplicates
def _get_nb_zone(self, name: str, view: str | None) -> pynetbox.core.response.Record:
def _get_nb_zone(self, name: str, view: pynb_resp.Record | None) -> pynb_resp.Record:
"""Given a zone name and a view name, look it up in NetBox.
Raises: pynetbox.RequestError if declared view is not existant"""
view_name = "null" if not view else view
nb_zone = self._api.plugins.netbox_dns.zones.get(name=name[:-1], view=view_name)
view = "null" if not view else view
nb_zone = self._api.plugins.netbox_dns.zones.get(name=name[:-1], view=view)
return nb_zone
@ -100,7 +100,7 @@ class NetBoxDNSSource(octodns.provider.base.BaseProvider):
records = {}
nb_zone = self._get_nb_zone(zone.name, view=self._nb_view.name)
nb_zone = self._get_nb_zone(zone.name, view=self._nb_view)
nb_records = self._api.plugins.netbox_dns.records.filter(zone_id=nb_zone.id)
for nb_record in nb_records:
@ -211,7 +211,7 @@ class NetBoxDNSSource(octodns.provider.base.BaseProvider):
f"_apply: zone={plan.desired.name}, len(changes)={len(plan.changes)}"
)
nb_zone = self._get_nb_zone(plan.desired.name, view=self._nb_view.name)
nb_zone = self._get_nb_zone(plan.desired.name, view=self._nb_view)
for change in plan.changes:
match change: